[Koha-bugs] [Bug 21798] New: We need t::lib::gimme_a_biblio

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Bug ID: 21798
Summary: We need t::lib::gimme_a_biblio
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: ***@bigballofwax.co.nz
Reporter: ***@gmail.com
QA Contact: ***@bugs.koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tomás Cohen Arazi <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|We need |We need
|t::lib::gimme_a_biblio |t::lib::TestBuilder::gimme_
| |a_biblio
Assignee|***@bigballofwax.co.nz |***@gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bug

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #1 from Tomás Cohen Arazi <***@gmail.com> ---
Created attachment 82116
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82116&action=edit
Bug 21798: We need t::lib::TestBuilder::gimme_a_biblio

Signed-off-by: Tomas Cohen Arazi <***@theke.io>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs :

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Marcel de Rooy <***@rijksmuseum.nl> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@rijksmuseum.nl
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #2 from Tomás Cohen Arazi <***@gmail.com> ---
Had to leave, will provide tests tomorrow
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http:/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #3 from Marcel de Rooy <***@rijksmuseum.nl> ---
The word gimme is not conform our naming standards imo :)
And gimme_a_biblio should imo not be in TestBuilder. We can already get a
biblio from TestBuilder. What you actually want is a simple MARC record in the
metadata table. I think your code should follow that design and keep
TestBuilder cleaner. Just my thought ;)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #4 from Tomás Cohen Arazi <***@gmail.com> ---
(In reply to Marcel de Rooy from comment #3)

Post by b***@bugs.koha-community.org
The word gimme is not conform our naming standards imo :)
And gimme_a_biblio should imo not be in TestBuilder. We can already get a
biblio from TestBuilder. What you actually want is a simple MARC record in
the metadata table. I think your code should follow that design and keep
TestBuilder cleaner. Just my thought ;)

I filed a bug to gather ideas on what to name the lib. I found it cool that we
already have a $builder objecet in many test files, so
$builder->gimme_a_biblio seemed reasonable. I know neither the name or the
place are fine. He.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.k

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Tomás Cohen Arazi <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@bugs.koha-c
| |ommunity.org,
| |***@gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http:

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #5 from Jonathan Druart <***@bugs.koha-community.org> ---
I am quite ok to create such methods in TestBuilder.pm

This new method will replace the multiple occurrences of:
* add_biblio
* create_helper_biblio
* get_biblio


We also will need methods to generate:
* a logged in patron (with correct flag, library, userenv)
* a superlibrarian patron
* a MARC record
* an item that can be checked out (itemtype, onloan, withdrawn, etc.)
* a checkout
* etc.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Jonathan Druart <***@bugs.koha-community.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Blocks| |21816


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21816
[Bug 21816] [OMNIBUS] Ease the write of our tests
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #6 from Marcel de Rooy <***@rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #5)

Post by b***@bugs.koha-community.org
I am quite ok to create such methods in TestBuilder.pm
* add_biblio
* create_helper_biblio
* get_biblio
* a logged in patron (with correct flag, library, userenv)
* a superlibrarian patron
* a MARC record
* an item that can be checked out (itemtype, onloan, withdrawn, etc.)
* a checkout
* etc.

Or create a TestBuilder dependent module? You want an interface between the
test and TestBuilder in order to shorten TestBuilder calls.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #7 from Jonathan Druart <***@bugs.koha-community.org> ---
Created attachment 82276
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82276&action=edit
Bug 21798: Unify the creation of bibliographic record in tests

Using the newly created subroutine
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #8 from Jonathan Druart <***@bugs.koha-community.org> ---
Created attachment 82277
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82277&action=edit
Bug 21798: Fix a wrong test

Now biblioitem.itemtype has a value, GetItem should fill itype with this
value if item-level_itypes it not set
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #9 from Jonathan Druart <***@bugs.koha-community.org> ---
Created attachment 82278
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82278&action=edit
Bug 21798: Fix another test

We should correctly generate the data we need, here we expect 2 records
with title starting with "Silence in the".
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

Jonathan Druart <***@bugs.koha-community.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@gmail.com |***@bugs.koha-c
| |ommunity.org
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #10 from Jonathan Druart <***@bugs.koha-community.org> ---
Created attachment 82943
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82943&action=edit
Bug 21798: Replace 2 more occurrences
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

David Cook <***@prosentient.com.au> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@prosentient.com.au
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798

--- Comment #11 from Marcel de Rooy <***@rijksmuseum.nl> ---
create_biblio ?
build_biblio ?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/