[Koha-bugs] [Bug 21950] New: Opac search with accented words error

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Bug ID: 21950
Summary: Opac search with accented words error
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P5 - low
Component: OPAC
Assignee: ***@myacpl.org
Reporter: ***@gmail.com
QA Contact: ***@bugs.koha-community.org

when we search for a term with accents in opac the first page appears normal,
but when we click to go to next page it presents an error.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Owen Leonard <***@myacpl.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version|18.11 |master

--- Comment #1 from Owen Leonard <***@myacpl.org> ---
I can confirm this in master. The accented character gets encoded in the
pagination links in such a way that it breaks the search.

é in the search string looks like %25C3%25A9

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Jonathan Druart <***@bugs.koha-community.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@bugs.koha-c
| |ommunity.org
Depends on| |21526, 21878


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526
[Bug 21526] TT variables used to build a link should be uri filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21878
[Bug 21878] Fix few links for opac pagination and facets (no uri filter)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Jonathan Druart <***@bugs.koha-community.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|***@myacpl.org |***@bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Jonathan Druart <***@bugs.koha-community.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Jonathan Druart <***@bugs.koha-community.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Summary|Opac search with accented |query_cgi and limit_cgi
|words error |must not be filtered
| |template-side
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

--- Comment #2 from Jonathan Druart <***@bugs.koha-community.org> ---
We must not escape query_cgi and limit_cgi template-side, they are already
escape properly from build_query_compat using uri_escape_utf8.

To fix further problems we should replace all occurrences to make things clear
(I decided to keep the html filter so far, which did not hurt, but uri or url
do)

Same patch as the following commit will be provided
commit 2fc599c0893620c395ca0492c9d9e3c860c8f951
Bug 21526: Fix search result pages (url vs uri vs raw)

query_cgi is uri_escaped from the pl, so we should displayed as raw

Test plan:
Use wide characters ❤
Search, filter, facets, search history, rss (both interfaces)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

--- Comment #3 from Jonathan Druart <***@bugs.koha-community.org> ---
Created attachment 82907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82907&action=edit
Bug 21950: Remove filtering for query_cgi and limit_cgi

We must not escape query_cgi and limit_cgi template-side, they are already
escape properly from build_query_compat using uri_escape_utf8.

To fix further problems we should replace all occurrences to make things
clear (I decided to keep the html filter so far, which did not hurt, but uri or
url do)

Same patch as the following commit will be provided
commit 2fc599c0893620c395ca0492c9d9e3c860c8f951
Bug 21526: Fix search result pages (url vs uri vs raw)

query_cgi is uri_escaped from the pl, so we should displayed as raw

Test plan:
Use wide characters ❤
Search, filter, facets, search history, rss (both interfaces)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-comm

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Jonathan Druart <***@bugs.koha-community.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

--- Comment #4 from Jonathan Druart <***@bugs.koha-community.org> ---
***Please test deeply!***
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

--- Comment #5 from victor <***@gmail.com> ---

Will the issue be fixed in the next update?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Owen Leonard <***@myacpl.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[b***@bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21950

Owen Leonard <***@myacpl.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #82907|0 |1
is obsolete| |

--- Comment #6 from Owen Leonard <***@myacpl.org> ---
Created attachment 83021
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83021&action=edit
Bug 21950: Remove filtering for query_cgi and limit_cgi

We must not escape query_cgi and limit_cgi template-side, they are already
escape properly from build_query_compat using uri_escape_utf8.

To fix further problems we should replace all occurrences to make things
clear (I decided to keep the html filter so far, which did not hurt, but uri or
url do)

Same patch as the following commit will be provided
commit 2fc599c0893620c395ca0492c9d9e3c860c8f951
Bug 21526: Fix search result pages (url vs uri vs raw)

query_cgi is uri_escaped from the pl, so we should displayed as raw

Test plan:
Use wide characters ❤
Search, filter, facets, search history, rss (both interfaces)

Signed-off-by: Owen Leonard <***@myacpl.org>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs :