[Koha-bugs] [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar

Discussion:

[Koha-bugs] [Bug 21905] Plugin hook intranet_catalog_biblio_enhancements_toolbar_button incorrectly filtered

b***@bugs.koha-community.org

2018-11-28 18:40:40 UTC

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Kyle M Hall <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |20968

Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968
[Bug 20968] Plugins: Add hooks to enable plugin integration into catalogue
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-28 18:40:45 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Kyle M Hall <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-***@lists.koha-commun |***@bywatersolutions.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-28 18:43:56 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

--- Comment #1 from Kyle M Hall <***@bywatersolutions.com> ---
Created attachment 82709
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82709&action=edit
Bug 21905: Plugin hook intranet_catalog_biblio_enhancements_toolbar_button
incorrectly filtered

The new plugin hook intranet_catalog_biblio_enhancements_toolbar_button is
rendered useless due to the outputted html being escaped using the html filter.
It should be using the raw filter instead.

Test Plan:
1) Enable plugins
2) Download and install the latest version of the Kitchen Sink plugin

https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.21/koha-plugin-kitchen-sink-v2.1.21.kpz
3) Browse to catalogue/detail.pl for a record
4) Note you see the raw html of the plugin output in the toolbar
5) Apply this patch
6) Restart all the things
7) Reload the page
8) Note the html is now correctly rendered as a button
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-28 18:44:09 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Kyle M Hall <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-28 18:43:53 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Kyle M Hall <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-29 08:43:13 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Andrew Isherwood <***@ptfs-europe.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@ptfs-europ
| |e.com

--- Comment #2 from Andrew Isherwood <***@ptfs-europe.com> ---
*** Bug 21900 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-29 10:19:24 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905
Bug 21905 depends on bug 20968, which changed state.

Bug 20968 Summary: Plugins: Add hooks to enable plugin integration into catalogue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20968

What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Stable |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-29 10:25:47 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Fridolin SOMERS <***@biblibre.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Depends on| |13618
CC| |***@biblibre.co
| |m

Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
[Bug 13618] Add additional template filter methods and a filter presence test
to Koha
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-29 10:28:37 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

--- Comment #3 from Fridolin SOMERS <***@biblibre.com> ---
raw filter comes from Bug 13618.

In 18.05.x and 17.11.x, html filter was removed from patch of Bug 20968
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-29 15:46:21 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Martin Renvoize <***@ptfs-europe.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |***@ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-29 15:46:07 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Martin Renvoize <***@ptfs-europe.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #82709|0 |1
is obsolete| |

--- Comment #4 from Martin Renvoize <***@ptfs-europe.com> ---
Created attachment 82756
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82756&action=edit
Bug 21905: Plugin hook intranet_catalog_biblio_enhancements_toolbar_button
incorrectly filtered

The new plugin hook intranet_catalog_biblio_enhancements_toolbar_button is
rendered useless due to the outputted html being escaped using the html filter.
It should be using the raw filter instead.

Test Plan:
1) Enable plugins
2) Download and install the latest version of the Kitchen Sink plugin

https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.21/koha-plugin-kitchen-sink-v2.1.21.kpz
3) Browse to catalogue/detail.pl for a record
4) Note you see the raw html of the plugin output in the toolbar
5) Apply this patch
6) Restart all the things
7) Reload the page
8) Note the html is now correctly rendered as a button

Signed-off-by: Martin Renvoize <***@ptfs-europe.com>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-11-29 15:46:45 UTC

Permalink

b***@bugs.koha-community.org

2018-11-29 19:17:30 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905

Nick Clemens <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
CC| |***@bywatersolutions.com

--- Comment #6 from Nick Clemens <***@bywatersolutions.com> ---
Awesome work everyone!

Pushed to master for 19.05
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-12-03 19:42:29 UTC

Permalink

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21905
Bug 21905 depends on bug 13618, which changed state.

Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

b***@bugs.koha-community.org

2018-12-10 09:49:05 UTC

Permalink