Discussion:
[Koha-bugs] [Bug 21649] New: Add child button in the staff client is no longer automatically populating the parent address
b***@bugs.koha-community.org
2018-10-24 17:21:55 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Bug ID: 21649
Summary: Add child button in the staff client is no longer
automatically populating the parent address
Change sponsored?: ---
Product: Koha
Version: 18.05
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Patrons
Assignee: koha-***@lists.koha-community.org
Reporter: ***@bywatersolutions.com
QA Contact: ***@bugs.koha-community.org
CC: ***@gmail.com, ***@gmail.com

In 18.05 when a staff member clicks the Add Child button on a
Parent's/Guardian's account the main address is not populated on the new patron
page. Other details carry over but the main address is empty.

I tested on a 17.11 instance and the feature works correctly there.

To Replicate:
1) Install/be running 18.05.04
2) Create or find an adult patron account you want to test with; make sure they
have an address - street, city, etc.
3) On the Details tab of the patron's record click on the "+Add child" button.
4) See that the main address text boxes are empty on the
/cgi-bin/koha/members/memberentry.pl?op=add&guarantorid=... page. The Guarantor
information and Contact information seems to come over, but Address does not.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-10-28 17:30:13 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Katrin Fischer <***@bsz-bw.de> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@bsz-bw.de
Keywords| |regression
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-19 14:48:47 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Nick Clemens <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-19 14:48:50 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

--- Comment #1 from Nick Clemens <***@bywatersolutions.com> ---
Created attachment 82510
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82510&action=edit
Bug 21649: Pass guarantee info to template when adding child

To test:
1 - Find an adult patron
2 - Click 'Add child'
3 - Note address/phone info does not carry over
4 - Apply patch
5 - Repeat
6 - Note information populates
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-19 14:49:15 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Nick Clemens <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Version|18.05 |master
CC| |***@bywatersolutions.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-19 14:50:38 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

--- Comment #2 from Nick Clemens <***@bywatersolutions.com> ---
*** Bug 21843 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-21 17:31:17 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Owen Leonard <***@myacpl.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #82510|0 |1
is obsolete| |

--- Comment #3 from Owen Leonard <***@myacpl.org> ---
Created attachment 82570
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82570&action=edit
Bug 21649: Pass guarantee info to template when adding child

To test:
1 - Find an adult patron
2 - Click 'Add child'
3 - Note address/phone info does not carry over
4 - Apply patch
5 - Repeat
6 - Note information populates

Signed-off-by: Owen Leonard <***@myacpl.org>
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-21 17:31:14 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Owen Leonard <***@myacpl.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-21 18:09:10 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

ByWater Sandboxes <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #82571|0 |1
is obsolete| |

--- Comment #5 from ByWater Sandboxes <***@gmail.com> ---
Created attachment 82572
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82572&action=edit
Bug 21649: Pass guarantee info to template when adding child

To test:
1 - Find an adult patron
2 - Click 'Add child'
3 - Note address/phone info does not carry over
4 - Apply patch
5 - Repeat
6 - Note information populates

Signed-off-by: Owen Leonard <***@myacpl.org>

Signed-off-by: Todd <***@gmail.com>

Signed-off-by: Todd <***@gmail.com>
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-21 18:08:46 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

ByWater Sandboxes <***@gmail.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #82570|0 |1
is obsolete| |

--- Comment #4 from ByWater Sandboxes <***@gmail.com> ---
Created attachment 82571
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82571&action=edit
Bug 21649: Pass guarantee info to template when adding child

To test:
1 - Find an adult patron
2 - Click 'Add child'
3 - Note address/phone info does not carry over
4 - Apply patch
5 - Repeat
6 - Note information populates

Signed-off-by: Owen Leonard <***@myacpl.org>

Signed-off-by: Todd <***@gmail.com>
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-23 08:07:06 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Marcel de Rooy <***@rijksmuseum.nl> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-23 08:07:09 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Marcel de Rooy <***@rijksmuseum.nl> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #82572|0 |1
is obsolete| |

--- Comment #6 from Marcel de Rooy <***@rijksmuseum.nl> ---
Created attachment 82597
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82597&action=edit
Bug 21649: Pass guarantee info to template when adding child

To test:
1 - Find an adult patron
2 - Click 'Add child'
3 - Note address/phone info does not carry over
4 - Apply patch
5 - Repeat
6 - Note information populates

Signed-off-by: Owen Leonard <***@myacpl.org>
Signed-off-by: Todd <***@gmail.com>

Signed-off-by: Marcel de Rooy <***@rijksmuseum.nl>
It works, but the code is ugly and hard to maintain.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-23 08:07:49 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Marcel de Rooy <***@rijksmuseum.nl> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@rijksmuseum.nl
Patch complexity|Trivial patch |Small patch

--- Comment #7 from Marcel de Rooy <***@rijksmuseum.nl> ---
Trivial is not the right qualification if you look for $patron, $newdata etc.
in memberentry
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-23 08:08:12 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Marcel de Rooy <***@rijksmuseum.nl> changed:

What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-***@lists.koha-commun |***@bywatersolutions.com
|ity.org |
QA Contact|***@bugs.koha-communit |***@rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-26 12:54:37 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Nick Clemens <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master

--- Comment #8 from Nick Clemens <***@bywatersolutions.com> ---
Awesome work all!

Pushed to master for 18.11
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-11-27 23:31:41 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Christopher Brannon <***@cdalibrary.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@cdalibrary.org

--- Comment #9 from Christopher Brannon <***@cdalibrary.org> ---
Will this be applied to 18.05?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-12-10 15:18:20 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Lucas Gass <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |***@bywatersolutions.com

--- Comment #10 from Lucas Gass <***@bywatersolutions.com> ---
This patch does not work for 18.05, not backporting
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
b***@bugs.koha-community.org
2018-12-10 20:17:22 UTC
Permalink
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21649

Lucas Gass <***@bywatersolutions.com> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable

--- Comment #13 from Lucas Gass <***@bywatersolutions.com> ---
backported to 18.05 for 18.05.07
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-***@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
Loading...